Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task instance details for each run #45273

Merged
merged 9 commits into from
Jan 3, 2025

Conversation

dauinh
Copy link
Contributor

@dauinh dauinh commented Dec 30, 2024

related: #44668

Screenshot 2024-12-29 at 8 16 46 PM Screenshot 2024-12-29 at 8 16 49 PM

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Dec 30, 2024
@jscheffl
Copy link
Contributor

jscheffl commented Jan 1, 2025

Note: As PR #45312 has been merged, the code formatting rules have changed for new UI. Please rebase and re-run pre-commit checks to ensure that formatting in folder airflow/ui is adjusted.

Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments and we need to reformat as Jens already mentioned.

airflow/ui/src/pages/Run/Details.tsx Outdated Show resolved Hide resolved
airflow/ui/src/pages/Run/Details.tsx Outdated Show resolved Hide resolved
@dauinh
Copy link
Contributor Author

dauinh commented Jan 2, 2025

I have rebased, made changes and run pre-commit checks as request, thank you!

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the page!

@jscheffl jscheffl merged commit 05fefb8 into apache:main Jan 3, 2025
34 checks passed
jscheffl added a commit that referenced this pull request Jan 3, 2025
jscheffl added a commit that referenced this pull request Jan 3, 2025
@dauinh dauinh deleted the add-task-instance-details branch January 3, 2025 18:16
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* init Details.tsx. add try number selector

* render try selector with latest try

* refactor to TrySelector.tsx

* add tooltip to try selector

* update with TaskTrySelect.tsx

* add table and populate fields

* rebasing. remove wrap button. change query for fetching task instance try details.
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants