Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SSH to authenticate GitDagBundle #44976

Merged
merged 19 commits into from
Jan 16, 2025

Conversation

ephraimbuddy
Copy link
Contributor

This uses SSH hook to authenticate GitDagBundle when provided.

@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Dec 17, 2024
@ephraimbuddy ephraimbuddy force-pushed the auth-git-dagbundle branch 2 times, most recently from 3806221 to 9537677 Compare December 18, 2024 15:18
@ephraimbuddy ephraimbuddy marked this pull request as ready for review December 18, 2024 16:20
airflow/dag_processing/bundles/git.py Outdated Show resolved Hide resolved
airflow/dag_processing/bundles/git.py Outdated Show resolved Hide resolved
tests/dag_processing/test_dag_bundles.py Outdated Show resolved Hide resolved
airflow/dag_processing/bundles/git.py Outdated Show resolved Hide resolved
airflow/dag_processing/bundles/git.py Outdated Show resolved Hide resolved
airflow/dag_processing/bundles/git.py Outdated Show resolved Hide resolved
airflow/dag_processing/bundles/git.py Outdated Show resolved Hide resolved
airflow/dag_processing/bundles/git.py Outdated Show resolved Hide resolved
airflow/dag_processing/bundles/git.py Outdated Show resolved Hide resolved
airflow/providers_manager.py Outdated Show resolved Hide resolved
airflow/providers_manager.py Outdated Show resolved Hide resolved
airflow/dag_processing/bundles/git.py Outdated Show resolved Hide resolved
airflow/dag_processing/bundles/git.py Show resolved Hide resolved
airflow/dag_processing/bundles/git.py Outdated Show resolved Hide resolved
tests/dag_processing/test_dag_bundles.py Outdated Show resolved Hide resolved
tests/dag_processing/test_dag_bundles.py Outdated Show resolved Hide resolved
@shahar1 shahar1 self-requested a review January 14, 2025 18:49
airflow/dag_processing/bundles/provider.yaml Outdated Show resolved Hide resolved
airflow/dag_processing/bundles/base.py Outdated Show resolved Hide resolved
@ephraimbuddy ephraimbuddy merged commit e7d8f5b into apache:main Jan 16, 2025
45 checks passed
@ephraimbuddy ephraimbuddy deleted the auth-git-dagbundle branch January 16, 2025 11:04
HariGS-DB pushed a commit to HariGS-DB/airflow that referenced this pull request Jan 16, 2025
* Use SSH to authenticate GitDagBundle

This uses SSH hook to authenticate GitDagBundle when provided.

* Add tests

* Account for remotes with ssh

* renames

* fix tests

* Refactor code

* Use githook

* fixup! Use githook

* Populate the connection form with git type connection

* Mark test_dag_bundles as db test

* Add names to the extra items

* Update airflow/dag_processing/bundles/git.py

Co-authored-by: Felix Uellendall <[email protected]>

* Fix refresh

* Apply suggestions from code review

Co-authored-by: Jed Cunningham <[email protected]>

* Remove ssh hook inheritance

* fixup! Remove ssh hook inheritance

* Apply suggestions from code review

Co-authored-by: Jed Cunningham <[email protected]>

* Fix code and link to dag processor

* Apply suggestions from code review

Co-authored-by: Jed Cunningham <[email protected]>

---------

Co-authored-by: Felix Uellendall <[email protected]>
Co-authored-by: Jed Cunningham <[email protected]>
dauinh pushed a commit to dauinh/airflow that referenced this pull request Jan 24, 2025
* Use SSH to authenticate GitDagBundle

This uses SSH hook to authenticate GitDagBundle when provided.

* Add tests

* Account for remotes with ssh

* renames

* fix tests

* Refactor code

* Use githook

* fixup! Use githook

* Populate the connection form with git type connection

* Mark test_dag_bundles as db test

* Add names to the extra items

* Update airflow/dag_processing/bundles/git.py

Co-authored-by: Felix Uellendall <[email protected]>

* Fix refresh

* Apply suggestions from code review

Co-authored-by: Jed Cunningham <[email protected]>

* Remove ssh hook inheritance

* fixup! Remove ssh hook inheritance

* Apply suggestions from code review

Co-authored-by: Jed Cunningham <[email protected]>

* Fix code and link to dag processor

* Apply suggestions from code review

Co-authored-by: Jed Cunningham <[email protected]>

---------

Co-authored-by: Felix Uellendall <[email protected]>
Co-authored-by: Jed Cunningham <[email protected]>
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* Use SSH to authenticate GitDagBundle

This uses SSH hook to authenticate GitDagBundle when provided.

* Add tests

* Account for remotes with ssh

* renames

* fix tests

* Refactor code

* Use githook

* fixup! Use githook

* Populate the connection form with git type connection

* Mark test_dag_bundles as db test

* Add names to the extra items

* Update airflow/dag_processing/bundles/git.py

Co-authored-by: Felix Uellendall <[email protected]>

* Fix refresh

* Apply suggestions from code review

Co-authored-by: Jed Cunningham <[email protected]>

* Remove ssh hook inheritance

* fixup! Remove ssh hook inheritance

* Apply suggestions from code review

Co-authored-by: Jed Cunningham <[email protected]>

* Fix code and link to dag processor

* Apply suggestions from code review

Co-authored-by: Jed Cunningham <[email protected]>

---------

Co-authored-by: Felix Uellendall <[email protected]>
Co-authored-by: Jed Cunningham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-66: DAG Bundle/Manifest area:Scheduler including HA (high availability) scheduler
Projects
Development

Successfully merging this pull request may close these issues.

5 participants