Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant vars from supervisor code #44974

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Dec 17, 2024

Afer we moved resp = None at the top-level, we don't need this.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Afer we moved `resp = None` at the top-level, we don't need this.
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just about to fix this today. It annoyed me yesterday. Thanks @kaxil!

@kaxil kaxil merged commit 8848d6e into apache:main Dec 17, 2024
45 checks passed
@kaxil kaxil deleted the remove-redundant-vars branch December 17, 2024 06:52
@kaxil kaxil added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Dec 17, 2024
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
Afer we moved `resp = None` at the top-level, we don't need this.
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
Afer we moved `resp = None` at the top-level, we don't need this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:task-sdk changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants