Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set container name to envSourceContainerName in KEDA ScaledObject #44963

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

jx2lee
Copy link
Contributor

@jx2lee jx2lee commented Dec 16, 2024

closes: #44798


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Dec 16, 2024
@jx2lee jx2lee force-pushed the keda-properly-work branch 2 times, most recently from cf262fe to 524267c Compare December 17, 2024 01:01
@jx2lee jx2lee marked this pull request as ready for review December 17, 2024 01:01
@eladkal eladkal added this to the Airflow Helm Chart 1.16.0 milestone Dec 17, 2024
Copy link

@yovio-rca yovio-rca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments regarding container name

chart/templates/triggerer/triggerer-kedaautoscaler.yaml Outdated Show resolved Hide resolved
chart/templates/workers/worker-kedaautoscaler.yaml Outdated Show resolved Hide resolved
@jx2lee jx2lee force-pushed the keda-properly-work branch from db25810 to 9e805ac Compare December 19, 2024 08:43
@jx2lee jx2lee changed the title Add envSourceContainerName to KEDA ScaledObject Set container name to envSourceContainerName in KEDA ScaledObject Dec 20, 2024
@jx2lee jx2lee force-pushed the keda-properly-work branch from 9e805ac to e84bfb8 Compare December 20, 2024 15:00
Copy link

@yovio-rca yovio-rca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jx2lee jx2lee force-pushed the keda-properly-work branch 2 times, most recently from ee22cd7 to 72ae21b Compare December 28, 2024 06:27
@jx2lee jx2lee force-pushed the keda-properly-work branch from 72ae21b to a75262a Compare January 3, 2025 07:39
@eladkal
Copy link
Contributor

eladkal commented Jan 9, 2025

Can you resolve conflicts and rebase?

@jx2lee jx2lee force-pushed the keda-properly-work branch 2 times, most recently from a75262a to c2e9835 Compare January 10, 2025 02:36
@jx2lee
Copy link
Contributor Author

jx2lee commented Jan 10, 2025

@eladkal Yes, Done!

@jx2lee jx2lee force-pushed the keda-properly-work branch 5 times, most recently from e0d7596 to c559d1e Compare January 15, 2025 11:25
@jx2lee jx2lee force-pushed the keda-properly-work branch from c559d1e to 3905bc0 Compare January 18, 2025 06:41
helm_tests/other/test_keda.py Outdated Show resolved Hide resolved
helm_tests/other/test_keda.py Show resolved Hide resolved
@jx2lee jx2lee force-pushed the keda-properly-work branch from 3905bc0 to 9062731 Compare January 22, 2025 11:37
@jx2lee jx2lee requested a review from jedcunningham January 22, 2025 11:57
@jx2lee jx2lee force-pushed the keda-properly-work branch from 64c7e1b to 28a8f9d Compare January 23, 2025 10:46
@jx2lee jx2lee force-pushed the keda-properly-work branch from 28a8f9d to 4924dc8 Compare January 27, 2025 01:35
@eladkal eladkal merged commit ca7c6ad into apache:main Jan 27, 2025
60 checks passed
vatsrahul1001 pushed a commit to astronomer/airflow that referenced this pull request Jan 27, 2025
@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 27, 2025
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keda does not work properly when using gitSync
5 participants