-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set container name to envSourceContainerName in KEDA ScaledObject #44963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jx2lee
force-pushed
the
keda-properly-work
branch
2 times, most recently
from
December 17, 2024 01:01
cf262fe
to
524267c
Compare
jx2lee
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
December 17, 2024 01:01
yovio-rca
suggested changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments regarding container name
jx2lee
force-pushed
the
keda-properly-work
branch
from
December 19, 2024 08:43
db25810
to
9e805ac
Compare
jx2lee
changed the title
Add envSourceContainerName to KEDA ScaledObject
Set container name to envSourceContainerName in KEDA ScaledObject
Dec 20, 2024
jx2lee
force-pushed
the
keda-properly-work
branch
from
December 20, 2024 15:00
9e805ac
to
e84bfb8
Compare
yovio-rca
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
jx2lee
force-pushed
the
keda-properly-work
branch
2 times, most recently
from
December 28, 2024 06:27
ee22cd7
to
72ae21b
Compare
jx2lee
force-pushed
the
keda-properly-work
branch
from
January 3, 2025 07:39
72ae21b
to
a75262a
Compare
Can you resolve conflicts and rebase? |
jx2lee
force-pushed
the
keda-properly-work
branch
2 times, most recently
from
January 10, 2025 02:36
a75262a
to
c2e9835
Compare
@eladkal Yes, Done! |
jx2lee
force-pushed
the
keda-properly-work
branch
5 times, most recently
from
January 15, 2025 11:25
e0d7596
to
c559d1e
Compare
jx2lee
force-pushed
the
keda-properly-work
branch
from
January 18, 2025 06:41
c559d1e
to
3905bc0
Compare
jx2lee
force-pushed
the
keda-properly-work
branch
from
January 22, 2025 11:37
3905bc0
to
9062731
Compare
jx2lee
force-pushed
the
keda-properly-work
branch
from
January 23, 2025 10:46
64c7e1b
to
28a8f9d
Compare
jx2lee
force-pushed
the
keda-properly-work
branch
from
January 27, 2025 01:35
28a8f9d
to
4924dc8
Compare
jedcunningham
approved these changes
Jan 27, 2025
eladkal
approved these changes
Jan 27, 2025
vatsrahul1001
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jan 27, 2025
…ache#44963) * add envSourceContainerName in ScaledObject
utkarsharma2
added
the
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
label
Jan 27, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…ache#44963) * add envSourceContainerName in ScaledObject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:helm-chart
Airflow Helm Chart
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #44798
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.