Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add asset events to dashboard #44961

Merged
merged 9 commits into from
Jan 23, 2025
Merged

Add asset events to dashboard #44961

merged 9 commits into from
Jan 23, 2025

Conversation

tirkarthi
Copy link
Contributor

@tirkarthi tirkarthi commented Dec 16, 2024 •
edited
Loading

Add asset events to dashboard to display the top 6 events sorted by default newest first (latest) asset events. The source links to the task instance the created the event. The selected time from filter is applied to the API to get only events in last 12 hours, past week etc. The triggered dagruns links to the dagruns triggered due to the asset event.

Notes to reviewer and self

  1. The UI prototype had small circle to denote the task instance and dagrun status but this might cause more API calls.
  2. The first dagrun is linked with the prototype a link to "+n more" where n are the remaining dagruns. But currently there is no asset page to link to for better information and how do we display the same.
  3. When there is from_rest_api it's usually from API and source is displayed as API. Similar can be done for asset events from trigger. Opened Add from_trigger field to AssetEvent extra for events from Trigger #44944 for discussion.
  4. The UI prototype displays asset.uri for the card. Do we need to display asset.name or asset.uri ?
  5. The variant should be flushed but typescript doesn't agree with the variant to remove border as per design.
  6. In case of no events does this section needs to be displayed?
  7. Padding, margin and other style comments welcome.

Related #42700

image

image

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Dec 16, 2024
@tirkarthi
Copy link
Contributor Author

cc: @uranusjr @Lee-W for feedback on asset events in UI

@Lee-W Lee-W self-requested a review December 16, 2024 15:36
@jscheffl
Copy link
Contributor

jscheffl commented Jan 1, 2025

Note: As PR #45312 has been merged, the code formatting rules have changed for new UI. Please rebase and re-run pre-commit checks to ensure that formatting in folder airflow/ui is adjusted.

pierrejeambrun
pierrejeambrun reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool.

Code looks good. No more suggestions than what's already been highlighted.

@tirkarthi tirkarthi requested review from XD-DENG and ashb as code owners January 6, 2025 16:26
@tirkarthi tirkarthi mentioned this pull request Jan 23, 2025
Merged
@bbovenzi bbovenzi merged commit 52fb4e0 into apache:main Jan 23, 2025
45 checks passed
dauinh pushed a commit to dauinh/airflow that referenced this pull request Jan 24, 2025
@tirkarthi @dauinh
Add asset events to dashboard (apache#44961)
d4a2cca 
* Add asset events section to dashboard.

* Add sort by to events widget.

* Revert trigger source changes. Style changes.

* Handle pydantica validation for asset uri which can be None.

* Fix tests.

* Add name and group to tooltip.

* Fix static checks.

* Use borderwidth and remove variant comment.

* Fix static check failure after rebase.
@utkarsharma2 utkarsharma2 added the type:new-feature Changelog: New Features label Jan 27, 2025
@utkarsharma2 utkarsharma2 added this to the Airflow 3.0.0 milestone Jan 27, 2025
gpathak128 pushed a commit to gpathak128/airflow that referenced this pull request Jan 29, 2025
@tirkarthi
Add asset events to dashboard (apache#44961)
9100bad 
* Add asset events section to dashboard.

* Add sort by to events widget.

* Revert trigger source changes. Style changes.

* Handle pydantica validation for asset uri which can be None.

* Fix tests.

* Add name and group to tooltip.

* Fix static checks.

* Use borderwidth and remove variant comment.

* Fix static check failure after rebase.
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
@tirkarthi @got686-yandex
Add asset events to dashboard (apache#44961)
466ca0b 
* Add asset events section to dashboard.

* Add sort by to events widget.

* Revert trigger source changes. Style changes.

* Handle pydantica validation for asset uri which can be None.

* Fix tests.

* Add name and group to tooltip.

* Fix static checks.

* Use borderwidth and remove variant comment.

* Fix static check failure after rebase.
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
@tirkarthi @niklasr22
Add asset events to dashboard (apache#44961)
57421f4 
* Add asset events section to dashboard.

* Add sort by to events widget.

* Revert trigger source changes. Style changes.

* Handle pydantica validation for asset uri which can be None.

* Fix tests.

* Add name and group to tooltip.

* Fix static checks.

* Use borderwidth and remove variant comment.

* Fix static check failure after rebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uranusjr uranusjr uranusjr left review comments

@Lee-W Lee-W Lee-W left review comments

@pierrejeambrun pierrejeambrun pierrejeambrun left review comments

@bbovenzi bbovenzi bbovenzi approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

Assignees
No one assigned
Labels
area:UI Related to UI/UX. For Frontend Developers. type:new-feature Changelog: New Features
Projects
None yet
Milestone
Airflow 3.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@tirkarthi @jscheffl @uranusjr @bbovenzi @Lee-W @pierrejeambrun @utkarsharma2