-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-82 Use hash
instead of repr
#44797
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
including HA (high availability) scheduler
label
Dec 9, 2024
hussein-awala
previously approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
vincbeck
force-pushed
the
vincbeck/aip-82-hash
branch
from
December 9, 2024 19:52
81e0282
to
8212e17
Compare
uranusjr
reviewed
Dec 9, 2024
hussein-awala
dismissed
their stale review
December 10, 2024 00:31
dismiss my review after TP comment
vincbeck
force-pushed
the
vincbeck/aip-82-hash
branch
2 times, most recently
from
December 11, 2024 20:39
6711957
to
ae19039
Compare
vincbeck
force-pushed
the
vincbeck/aip-82-hash
branch
from
December 17, 2024 21:22
ae19039
to
8db70ef
Compare
ferruzzi
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the discussion in the comments section, I think this looks pretty straight-forward.
vincbeck
force-pushed
the
vincbeck/aip-82-hash
branch
from
December 19, 2024 23:38
8db70ef
to
15936d7
Compare
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Jan 6, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this conversation, it is better to use
hash
instead ofrepr
to identify an object.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.