Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-82 Use hash instead of repr #44797

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

vincbeck
Copy link
Contributor

@vincbeck vincbeck commented Dec 9, 2024

Based on this conversation, it is better to use hash instead of repr to identify an object.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@vincbeck vincbeck requested a review from dstandish December 9, 2024 19:13
@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Dec 9, 2024
hussein-awala
hussein-awala previously approved these changes Dec 9, 2024
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@vincbeck vincbeck force-pushed the vincbeck/aip-82-hash branch from 81e0282 to 8212e17 Compare December 9, 2024 19:52
@hussein-awala hussein-awala dismissed their stale review December 10, 2024 00:31

dismiss my review after TP comment

@vincbeck vincbeck force-pushed the vincbeck/aip-82-hash branch 2 times, most recently from 6711957 to ae19039 Compare December 11, 2024 20:39
@vincbeck vincbeck force-pushed the vincbeck/aip-82-hash branch from ae19039 to 8db70ef Compare December 17, 2024 21:22
Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the discussion in the comments section, I think this looks pretty straight-forward.

@vincbeck vincbeck force-pushed the vincbeck/aip-82-hash branch from 8db70ef to 15936d7 Compare December 19, 2024 23:38
@vincbeck vincbeck merged commit cd2ad3c into apache:main Dec 20, 2024
49 checks passed
@vincbeck vincbeck deleted the vincbeck/aip-82-hash branch December 20, 2024 15:25
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Jan 6, 2025
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler including HA (high availability) scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants