-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DMS Serverless Operators #43988
Add DMS Serverless Operators #43988
Conversation
a3b49bf
to
5ce341d
Compare
The current error in the CI is a valid one: You'll need to add example dags or exclude if there is a reason |
Co-authored-by: Niko Oliveira <[email protected]>
Co-authored-by: Niko Oliveira <[email protected]>
Co-authored-by: Niko Oliveira <[email protected]>
Co-authored-by: Elad Kalif <[email protected]>
Co-authored-by: Elad Kalif <[email protected]>
c2a1f3c
to
efbf597
Compare
Added the missing example. |
Test fail :(
|
28bc513
to
25e9dee
Compare
revert change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It seems the merge of this PR broke tests on main/canary builds: Somebody having an idea how to fix? Shall we revert? |
Okay, I thought I make a "quick fix" and add aiobotocore as dependency... but there is a bit of history and even as pre-commit check NOT to add this. |
Fix merged in #45013 |
"MaxCapacityUnits": 4, | ||
"MinCapacityUnits": 1, | ||
"MultiAZ": False, | ||
"ReplicationSubnetGroupId": "default", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test fails with the following stack trace:
Traceback (most recent call last):
File "/opt/airflow/providers/src/airflow/providers/amazon/aws/hooks/dms.py", line 281, in create_replication_config
resp = self.conn.create_replication_config(
File "/usr/local/lib/python3.9/site-packages/botocore/client.py", line 569, in _api_call
return self._make_api_call(operation_name, kwargs)
File "/usr/local/lib/python3.9/site-packages/botocore/client.py", line 1023, in _make_api_call
raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (InvalidParameterValueException) when calling the CreateReplicationConfig operation: The provided value 'default' for field 'ReplicationSubnetGroupId' does not exist. Please verify the replication subnet group exists
Does it perhaps need a step to create (and later delete) a replication subnet group? (using this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd, let me look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any luck?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I'm having a problem running the DAG in Breeze. It seems the xcoms aren't being stored from tasks such as get_vpc_id
, so when subsequent tasks try to use those values, they are missing. Even though the logs say valid values are returned. Haven't been able to track down what's going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not stored at all or stored with different id?
The task in question is wrapped with task group but the xcom pull is missing the group id
https://stackoverflow.com/a/72137722/14624409
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's being stored. When I view the get_default_vpc_id
task in the Airflow UI, the Xcom table says "No Xcom". I confirmed the Xcom table in the databse is empty. The task log, however, shows the return value I expect:
{"logger":"airflow.task.operators.airflow.decorators.python._PythonDecoratedOperator","timestamp":"2025-01-07T19:21:51.381738","event":"Done. Returned value was: vpc-067c44fffb613cda6","level":"info"}
I didn't encounter this when I initially made the PR - everything worked. Has something changed?
* Adding DMS serverless operators --------- Co-authored-by: Niko Oliveira <[email protected]> Co-authored-by: mse139 <[email protected]> Co-authored-by: Elad Kalif <[email protected]>
* Adding DMS serverless operators --------- Co-authored-by: Niko Oliveira <[email protected]> Co-authored-by: mse139 <[email protected]> Co-authored-by: Elad Kalif <[email protected]>
Adding operators, waiters, and triggers to support AWS DMS Serverless replications.
closes #39954