Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Jed Cunningham <[email protected]>
  • Loading branch information
ephraimbuddy and jedcunningham committed Jan 15, 2025
1 parent 455e3b7 commit de27d21
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions tests/dag_processing/test_dag_bundles.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,6 @@ def test_uses_dag_bundle_root_storage_path(self, git_repo):

@mock.patch("airflow.dag_processing.bundles.git.GitHook")
def test_get_current_version(self, mock_githook, git_repo):
mock_githook.get_conn.return_value = mock.MagicMock()
repo_path, repo = git_repo
mock_githook.return_value.repo_url = repo_path
bundle = GitDagBundle(name="test", refresh_interval=300, tracking_ref=GIT_DEFAULT_BRANCH)
Expand Down Expand Up @@ -423,7 +422,7 @@ def test_refresh_with_git_connection(self, mock_gitRepo, mock_hook):
],
)
@mock.patch("airflow.dag_processing.bundles.git.GitHook")
def test_repo_url_starts_with_git_when_using_ssh_conn_id(self, mock_hook, repo_url, session):
def test_repo_url_validation_for_ssh(self, mock_hook, repo_url, session):
mock_hook.get_conn.return_value = mock.MagicMock()
mock_hook.return_value.repo_url = repo_url
bundle = GitDagBundle(
Expand Down

0 comments on commit de27d21

Please sign in to comment.