Skip to content

Commit

Permalink
Fix the errors (hopefully all)
Browse files Browse the repository at this point in the history
  • Loading branch information
andrii-korotkov-verkada committed Dec 29, 2024
1 parent eafcf1b commit d28bbe6
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
2 changes: 1 addition & 1 deletion chart/templates/pgbouncer/pgbouncer-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ spec:
{{- if $containerLifecycleHooksMetricsExporter }}
lifecycle: {{- tpl (toYaml $containerLifecycleHooksMetricsExporter) . | nindent 12 }}
{{- end }}
{{- if or .Values.pgbouncer.metricsExporterSidecar.extraVolumeMounts }}
{{- if .Values.pgbouncer.metricsExporterSidecar.extraVolumeMounts }}
volumeMounts:
{{- tpl (toYaml .Values.pgbouncer.metricsExporterSidecar.extraVolumeMounts) . | nindent 12 }}
{{- end}}
Expand Down
2 changes: 1 addition & 1 deletion chart/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -7085,7 +7085,7 @@
"default": null
},
"mountConfigSecret": {
"description": "Whether to mount the config secret files at a default location (/etc/pgbouncer/*).",
"description": "Whether to mount the config secret files under /etc/pgbouncer/ by default.",
"type": "boolean",
"x-docsSection": "Common",
"default": true
Expand Down
14 changes: 9 additions & 5 deletions helm_tests/other/test_pgbouncer.py
Original file line number Diff line number Diff line change
Expand Up @@ -738,10 +738,12 @@ def test_unused_secret_key(self):
}

def test_extra_volume_mounts(self):
extra_volume_mounts = [{
"name": "test-volume",
"mountPath": "/mnt/test_volume",
}]
extra_volume_mounts = [
{
"name": "test-volume",
"mountPath": "/mnt/test_volume",
}
]

docs = render_chart(
"test-pgbouncer-stats",
Expand All @@ -757,7 +759,9 @@ def test_extra_volume_mounts(self):
show_only=["templates/pgbouncer/pgbouncer-deployment.yaml"],
)

assert jmespath.search("spec.template.spec.containers[1].volumeMounts", docs[0]) == extra_volume_mounts
assert (
jmespath.search("spec.template.spec.containers[1].volumeMounts", docs[0]) == extra_volume_mounts
)


class TestPgBouncerServiceAccount:
Expand Down

0 comments on commit d28bbe6

Please sign in to comment.