Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler: simplify spawn with macro #4953

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Scheduler: simplify spawn with macro #4953

wants to merge 3 commits into from
+41 −56

Conversation

apfitzge
Copy link

Problem

  • Duplicate code due to differing types
  • Want to consolidate the code so we don't mess it up

Summary of Changes

  • Add a macro to spawn scheduler, given the initialized scheduler

Fixes #

apfitzge
apfitzge commented Feb 12, 2025
View reviewed changes
core/src/banking_stage.rs
.name("solBnkTxSched".to_string())
.spawn(move || {
let scheduler_controller = SchedulerController::new(
decision_maker,
Copy link
Author

@apfitzge apfitzge Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed a useless clone here - otherwise this was copied exactly from the previous branches, with exception of $scheduler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@apfitzge