Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler: Add common struct and implementation #4952

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Scheduler: Add common struct and implementation #4952

wants to merge 4 commits into from

Conversation

apfitzge
Copy link

Problem

  • PrioGraphScheduler and GreedyScheduler have quite a bit of duplicate fields and code

Summary of Changes

  • create scheduler_common.rs to host common data and functions

Fixes #

apfitzge
apfitzge commented Feb 12, 2025
View reviewed changes
core/src/banking_stage/transaction_scheduler/scheduler.rs

/// All schedulers should have access to the common context for shared
/// implementation.
fn scheduling_common_mut(&mut self) -> &mut SchedulingCommon<Tx>;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here so above fn can have shared implementation.

@apfitzge apfitzge marked this pull request as ready for review February 13, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bw-solana bw-solana Awaiting requested review from bw-solana

@tao-stones tao-stones Awaiting requested review from tao-stones

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@apfitzge