Uses enum to specify if AccountsIndexIterator should return items sorted or not #4937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
scan-config/unsorted/index-iterator
branch
from
87e73fc to
f082da2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
collect_all_unsortedfield on the accounts index iterator is sometimes cumbersome due to (1) it being a bool, and (2) it feeling backwards/negative from its true/false meaning.Summary of Changes
Use an enum instead. This way it is self documenting.
Note this PR purposely doesn't change
collect_all_unsortedin ScanConfig. That'll be another PR.