agave-validator: add args tests for set-identity #4929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihau
force-pushed
the
add-set-identity-test
branch
from
85fc50f to
57e6304
Compare
steviez
reviewed
Feb 14, 2025
| const COMMAND: &str = "set-identity"; | ||
|
|
||
| #[derive(Debug, PartialEq)] | ||
| pub struct SetIdentityArg { |
There was a problem hiding this comment.
nit: SetIdentityArg ==> SetIdentityArgs
steviez
reviewed
Feb 14, 2025
Comment on lines
+49
to
+50
| let set_identity_args = SetIdentityArgs::from_clap_arg_match(matches); | ||
| let require_tower = set_identity_args.require_tower; |
There was a problem hiding this comment.
nit: Let's just destructure the return value:
let SetIdentityArgs {
identity,
require_tower
} = SetIdentityArgs::from_clap_arg_match(matches);
steviez
reviewed
Feb 14, 2025
Comment on lines
+117
to
+119
| let tmp_path = tmp_dir.path().join("id.json"); | ||
| let keypair_string = "[99,66,147,169,175,95,166,214,27,255,19,64,81,255,101,39,10,24,205,48,226,191,98,234,210,86,174,34,2,121,173,223,9,36,145,159,1,95,129,252,249,189,217,191,13,169,231,216,4,181,124,105,193,20,61,251,197,68,44,240,205,70,115,226]"; | ||
| std::fs::write(&tmp_path, keypair_string).unwrap(); |
There was a problem hiding this comment.
I think we can make this significantly easier:
let file = tmp_dir.path().join("id.json");
let keypair = Keypair::new();
solana_keypair::write_keypair_file(&keypair, file).unwrap();Basically, avoid the hard-coded string + use the helper here:
https://github.com/anza-xyz/solana-sdk/blob/f93ad76f6a051550b8ceb7301813553112d1d4e2/keypair/src/lib.rs#L261-L267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#4082
Summary of Changes
extracting args parsing logic and adding tests