agave-validator: add args tests for set-public-address #4922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihau
force-pushed
the
add-set-public-address-test
branch
from
b84c20c to
85c8f4d
Compare
steviez
reviewed
Feb 14, 2025
| const COMMAND: &str = "set-public-address"; | ||
|
|
||
| #[derive(Debug, PartialEq)] | ||
| pub struct SetPublicAddressArg { |
There was a problem hiding this comment.
nit: SetPublicAddressArg ==> SetPublicAddressArgs
yihau
force-pushed
the
add-set-public-address-test
branch
from
1053e09 to
8f90ec1
Compare
steviez
reviewed
Feb 14, 2025
| "Failed to parse --{arg_long} address. It must be in the HOST:PORT \ | ||
| format. {err}" | ||
| ); | ||
| exit(1); |
There was a problem hiding this comment.
Hard to unit test something that exits; let's hold here until we figure out what direction we want to go with error handling in #4923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#4082
Summary of Changes
extracting args parsing logic and adding tests