Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define is_nonverlapping function in solana-bpf-loader-program #4888

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kevinheavey
Copy link

@kevinheavey kevinheavey commented Feb 10, 2025

Problem

This function is currently defined in solana-program-memory but is hidden so as not to be part of the API. It brings along a num-traits dep. The version of it that is used in solana-program-memory does not need num-traits. Since it is a very small function, I think it's fine to have two similar definitions of it, both of which are private

Summary of Changes

Define it in solana-bpf-loader-program. I am making a separate PR to solana-sdk to remove num-traits from that one

@kevinheavey kevinheavey requested a review from a team as a code owner February 10, 2025 10:08
Copy link

mergify bot commented Feb 10, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@kevinheavey kevinheavey force-pushed the move-is-nonoverlapping branch from 7442e72 to a6388de Compare February 14, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant