define is_nonverlapping function in solana-bpf-loader-program #4888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This function is currently defined in solana-program-memory but is hidden so as not to be part of the API. It brings along a num-traits dep. The version of it that is used in solana-program-memory does not need num-traits. Since it is a very small function, I think it's fine to have two similar definitions of it, both of which are private
Summary of Changes
Define it in solana-bpf-loader-program. I am making a separate PR to solana-sdk to remove num-traits from that one