Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Feature - Adds UpgradeableLoaderInstruction::Migrate (#4661)" #4870

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

joncinque
Copy link

Problem

#4661 introduced a change to the loader-v3 instruction after the v2.2 branch was cut, which means that we currently cannot remove the sdk from agave with #4867

Summary of Changes

Revert commit 11dfda5.

@joncinque joncinque requested review from Lichtso and LucasSte February 7, 2025 23:33
@joncinque joncinque requested a review from a team as a code owner February 7, 2025 23:33
Copy link

mergify bot commented Feb 7, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@joncinque joncinque requested a review from willhickey February 7, 2025 23:50
Copy link

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, since this will unblock removing the SDK.

@joncinque joncinque merged commit 3bbe4ca into anza-xyz:master Feb 8, 2025
77 checks passed
@joncinque joncinque deleted the revertmigrate branch February 8, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants