Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI - loader v3 to v4 migration #4856

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Feb 7, 2025

Problem

Split off from #4661 as requested (#4661 (review)).

Summary of Changes

Adds a CLI subcommand for migrating loader-v3 programs to loader-v4.

@Lichtso Lichtso requested a review from a team as a code owner February 7, 2025 14:40
Copy link

mergify bot commented Feb 7, 2025

⚠️ The sha of the head commit of this PR conflicts with #4661. Mergify cannot evaluate rules on this PR. ⚠️

@@ -13381,6 +13381,180 @@ fn test_deploy_last_epoch_slot() {
assert_eq!(result_with_feature_enabled, Ok(()));
}

#[test]
fn test_loader_v3_to_v4_migration() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is in #4661, isn't it?

@@ -4255,6 +4418,46 @@ mod tests {
);
}

#[test]
fn test_cli_parse_migrate_program() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we test the error paths too?

Copy link

mergify bot commented Feb 7, 2025

⚠️ The sha of the head commit of this PR conflicts with #4661. Mergify cannot evaluate rules on this PR. ⚠️

@Lichtso Lichtso force-pushed the cli/loader_v3_to_v4_migration branch from 7d0f4d0 to 8889a6c Compare February 7, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants