Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added twitter share logo and simple css proerty change #49

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Nikhil27b
Copy link

please review if you want to add more UX changes then comment I am good at frontend UX and UI.

I added a twitter share logo for the website and some CSS property changes

@vercel
Copy link

vercel bot commented Oct 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/anup-a/svgwave/H2ovYRfAf8ouzUBpJR4vBJKFWkM5
✅ Preview: https://svgwave-git-fork-nikhil27b-main-anup-a.vercel.app

[Deployment for 4d04c45 failed]

@Nikhil27b
Copy link
Author

@anup-a Please check out this pull request

@anup-a
Copy link
Owner

anup-a commented Oct 3, 2021

@Nikhil27b Hey thanks for the PR. I'm sorry, busy atm. I'll review it by tomorrow.

Copy link
Owner

@anup-a anup-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code. Thanks for the PR. Would you please take a look at commets

@@ -20,9 +20,11 @@
"author": "Anup Aglawe",
"license": "ISC",
"dependencies": {
"postcss": "^8.3.8",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add postcss in deps?


export default CustomBar

import { h } from 'preact'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something looks messed up here?

@@ -17,6 +21,21 @@ function Navbar({ isDark, toggleDarkMode, color }) {
</div>
</div>
<div className="flex items-center nav-item ">
<div style={{marginRight: '0.5rem', marginTop: '0.5rem' }}>
Copy link
Owner

@anup-a anup-a Oct 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • No responsive/mobile friendly styles.
  • And logo doesn't go with the theme (a black outline twitter logo would look much better).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants