Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复移动端禁用外部容器滚动不生效 #3097

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Feb 10, 2025

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link
Contributor

你好 @lijinke666,非常感谢你的贡献.
为了让代码更健壮, 请根据 贡献指南 补充相应单元测试 (文档改动或其他特殊场景除外), 如果有 API 改动, 请修改 相应的文档.
同时请检查 linttest 相关 CI 是否通过, 如果失败, 请点击 [Details] 按钮查看, 并根据日志修复.

Hello, @lijinke666, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.
At the same time, please check whether the CI related to lint and test passes. If the CI fails, please click [Details] button to check and repair according to the log.

@github-actions github-actions bot added the pr(fix) bug fix label Feb 10, 2025
@github-actions github-actions bot requested a review from Alexzjt February 10, 2025 08:17
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Feb 10, 2025
Copy link

Walkthrough

此PR修复了在移动端禁用外部容器滚动不生效的问题。通过使用G库中的原生TouchEvent,确保在移动设备上可以正确阻止外部容器的滚动。

Changes

文件 概要
packages/s2-core/src/facet/base-facet.ts 修复了移动端禁用外部容器滚动的问题,使用原生TouchEvent替代原有的GraphEvent。

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.10%. Comparing base (ecdc9c8) to head (efedf7a).
Report is 618 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3097      +/-   ##
==========================================
+ Coverage   75.77%   80.10%   +4.33%     
==========================================
  Files         257      179      -78     
  Lines       11994    10800    -1194     
  Branches     2464     2450      -14     
==========================================
- Hits         9088     8651     -437     
+ Misses       1398      663     -735     
+ Partials     1508     1486      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Size Change: +5 B (0%)

Total Size: 619 kB

Filename Size Change
./packages/s2-core/dist/s2.min.js 257 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2-extends.min.js 154 kB
./packages/s2-core/dist/s2.min.css 581 B
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 124 kB
./packages/s2-react/dist/s2-react.min.css 1.74 kB
./packages/s2-react/dist/s2-react.min.js 38.3 kB
./packages/s2-vue/dist/s2-vue.min.css 2.05 kB
./packages/s2-vue/dist/s2-vue.min.js 38.3 kB

compressed-size-action

@Alexzjt Alexzjt merged commit ba93684 into next Feb 10, 2025
16 checks passed
@Alexzjt Alexzjt deleted the fix-mobile-wheel branch February 10, 2025 08:46
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.1.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @latest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛移动端 图表滚动问题
3 participants