Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复明细表空数据占位符背景穿透的问题 close #3077 #3079

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Jan 14, 2025

👀 PR includes

🐛 Bugfix

📝 Description

🖼️ Screenshot

Before After
image
image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@github-actions github-actions bot added pr(fix) bug fix next 2.0-next 版本的问题 labels Jan 14, 2025
Copy link

Walkthrough

此 PR 修复了明细表中空数据占位符背景穿透的问题。通过调整背景颜色的设置,确保占位符的背景不再穿透到其他层次。

Changes

文件 概要
packages/s2-core/src/facet/table-facet.ts 修复了空数据占位符背景穿透的问题,添加了背景颜色设置,并调整了占位符的层次顺序。

@github-actions github-actions bot requested a review from wjgogogo January 14, 2025 06:50
Copy link
Contributor

你好 @lijinke666,非常感谢你的贡献.
为了让代码更健壮, 请根据 贡献指南 补充相应单元测试 (文档改动或其他特殊场景除外), 如果有 API 改动, 请修改 相应的文档.
同时请检查 linttest 相关 CI 是否通过, 如果失败, 请点击 [Details] 按钮查看, 并根据日志修复.

Hello, @lijinke666, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.
At the same time, please check whether the CI related to lint and test passes. If the CI fails, please click [Details] button to check and repair according to the log.

@@ -124,6 +124,7 @@ export class TableFacet extends FrozenFacet {
}

const { empty } = this.spreadsheet.options.placeholder!;
const { background } = this.spreadsheet.theme;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确保 background 对象存在,以避免在访问其 color 属性时出现潜在的运行时错误。可以考虑在使用前进行空值检查。

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.77%. Comparing base (ecdc9c8) to head (6b5326f).
Report is 599 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3079      +/-   ##
==========================================
  Coverage   75.77%   75.77%              
==========================================
  Files         257       51     -206     
  Lines       11994     1490   -10504     
  Branches     2464      284    -2180     
==========================================
- Hits         9088     1129    -7959     
+ Misses       1398      210    -1188     
+ Partials     1508      151    -1357     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Size Change: 0 B

Total Size: 619 kB

ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2-extends.min.js 154 kB
./packages/s2-core/dist/s2.min.css 581 B
./packages/s2-core/dist/s2.min.js 257 kB
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 124 kB
./packages/s2-react/dist/s2-react.min.css 1.74 kB
./packages/s2-react/dist/s2-react.min.js 38.3 kB
./packages/s2-vue/dist/s2-vue.min.css 2.05 kB
./packages/s2-vue/dist/s2-vue.min.js 38.3 kB

compressed-size-action

@lijinke666 lijinke666 changed the title fix: 修复明细表空数据占位符背景穿透的问题 close #3077 [WIP] fix: 修复明细表空数据占位符背景穿透的问题 close #3077 Jan 14, 2025
@github-actions github-actions bot removed the pr(fix) bug fix label Jan 14, 2025
@lijinke666 lijinke666 changed the title [WIP] fix: 修复明细表空数据占位符背景穿透的问题 close #3077 fix: 修复明细表空数据占位符背景穿透的问题 close #3077 Jan 17, 2025
@github-actions github-actions bot added the pr(fix) bug fix label Jan 17, 2025
@lijinke666 lijinke666 merged commit 4d2f941 into next Jan 17, 2025
7 of 8 checks passed
@lijinke666 lijinke666 deleted the fix-3077 branch January 17, 2025 02:26
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.1.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @latest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 TableSheet 在滚动时添加数据,然后在搜索过滤的时候,会出现视图异常
3 participants