-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 修复明细表空数据占位符背景穿透的问题 close #3077 #3079
Conversation
Walkthrough此 PR 修复了明细表中空数据占位符背景穿透的问题。通过调整背景颜色的设置,确保占位符的背景不再穿透到其他层次。 Changes
|
你好 @lijinke666,非常感谢你的贡献. Hello, @lijinke666, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes. |
@@ -124,6 +124,7 @@ export class TableFacet extends FrozenFacet { | |||
} | |||
|
|||
const { empty } = this.spreadsheet.options.placeholder!; | |||
const { background } = this.spreadsheet.theme; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
确保 background
对象存在,以避免在访问其 color
属性时出现潜在的运行时错误。可以考虑在使用前进行空值检查。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3079 +/- ##
==========================================
Coverage 75.77% 75.77%
==========================================
Files 257 51 -206
Lines 11994 1490 -10504
Branches 2464 284 -2180
==========================================
- Hits 9088 1129 -7959
+ Misses 1398 210 -1188
+ Partials 1508 151 -1357 ☔ View full report in Codecov by Sentry. |
Size Change: 0 B Total Size: 619 kB ℹ️ View Unchanged
|
🎉 This PR is included in version @antv/s2-v2.1.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
🐛 Bugfix
📝 Description
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge