fix: 修复单元格宽度为浮点数时单元格之间有几率出现多余空隙的问题 close #3014

[lijinke666]

👀 PR includes

🐛 Bugfix

• Solve the issue and close 🐛角头单元格垂直边线透明度或者宽度设置为0时不生效 #3014

📝 Description

背景见 #3014 (comment)

G 的底层默认有取整处理, 对于 S2 单元格来说, 如果宽度是浮点数 199.2, 实际渲染的可能是 200, 会导致有 1px 偏差, 出现多余空隙.

解法: 将宽高统一进行向下取整处理

🖼️ Screenshot

Before	After

🔗 Related issue link

🔍 Self-Check before the merge

• Add or update relevant docs.
• Add or update relevant demos.
• Add or update test case.
• Add or update relevant TypeScript definitions.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
antvis-s2	❌ Failed (Inspect)			Jan 3, 2025 9:42am

[github-actions]

你好 @lijinke666，非常感谢你的贡献.
为了让代码更健壮, 请根据 贡献指南 补充相应单元测试 (文档改动或其他特殊场景除外), 如果有 API 改动, 请修改 相应的文档.
同时请检查 lint 和 test 相关 CI 是否通过, 如果失败, 请点击 [Details] 按钮查看, 并根据日志修复.

Hello, @lijinke666, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.
At the same time, please check whether the CI related to lint and test passes. If the CI fails, please click [Details] button to check and repair according to the log.

[petercat-assistant]

Walkthrough

This PR addresses a bug where cells with floating-point widths in the S2 library rendered with extra gaps due to rounding issues in the underlying G library. The solution involves rounding the width and height values to ensure consistent rendering without gaps.

Changes

Files	Summary
packages/s2-core/__tests__/bugs/issue-3014-spec.ts	Added a test to verify that sub-pixel rendering issues are resolved.
packages/s2-core/__tests__/spreadsheet/__snapshots__/multi-line-text-spec.ts.snap	Updated snapshot tests to reflect changes in rendering.
packages/s2-core/src/extends/pivot-chart/facet/pivot-chart-facet.ts packages/s2-core/src/facet/base-facet.ts packages/s2-core/src/facet/pivot-facet.ts packages/s2-core/src/facet/table-facet.ts packages/s2-core/src/interaction/row-column-resize.ts	Modified functions to use round for width and height calculations to prevent rendering gaps.
packages/s2-core/src/utils/math.ts	Added a new round function to handle rounding operations.

🪧 Tips

For further assistance, please describe your question in the comments and @petercat-assistant to start a conversation with me.

[petercat-assistant]

Ensure that the round function is correctly handling non-numeric inputs by returning the input value unchanged. This is crucial for preventing unexpected behavior in the application.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.77%. Comparing base (ecdc9c8) to head (c1e87ff).
Report is 588 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #3066      +/-   ##
==========================================
  Coverage   75.77%   75.77%              
==========================================
  Files         257       51     -206     
  Lines       11994     1490   -10504     
  Branches     2464      284    -2180     
==========================================
- Hits         9088     1129    -7959     
+ Misses       1398      210    -1188     
+ Partials     1508      151    -1357     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Size Change: +47 B (+0.01%)

Total Size: 619 kB

Filename	Size	Change
./packages/s2-core/dist/s2-extends.min.js	154 kB	+10 B (+0.01%)
./packages/s2-core/dist/s2.min.js	257 kB	+37 B (+0.01%)

ℹ️ View Unchanged

Filename	Size
./packages/s2-core/dist/s2.min.css	581 B
./packages/s2-react-components/dist/s2-react-components.min.css	2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js	124 kB
./packages/s2-react/dist/s2-react.min.css	1.74 kB
./packages/s2-react/dist/s2-react.min.js	38.3 kB
./packages/s2-vue/dist/s2-vue.min.css	2.05 kB
./packages/s2-vue/dist/s2-vue.min.js	38.3 kB

_{compressed-size-action}

[lijinke666]

🎉 This PR is included in version @antv/s2-v2.1.8 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀