fix: memory leak caused by function cache

antvis · Jan 17, 2025 · bab64ee · bab64ee
1 parent bc84b68
commit bab64ee
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/.changeset/wise-birds-begin.md b/.changeset/wise-birds-begin.md
@@ -0,0 +1,5 @@
+---
+'@antv/g-lite': patch
+---
+
+fix: memory leak caused by function cache
diff --git a/packages/g-lite/src/Canvas.ts b/packages/g-lite/src/Canvas.ts
@@ -44,6 +44,7 @@ import {
   isBrowser,
   isInFragment,
   raf,
+  memoize,
 } from './utils';
 
 export function isCanvas(value: any): value is Canvas {
@@ -352,6 +353,8 @@ export class Canvas extends EventTarget implements ICanvas {
    * @param skipTriggerEvent - whether to skip trigger destroy event
    */
   destroy(cleanUp = true, skipTriggerEvent?: boolean) {
+    memoize.clearCache();
+
     if (!skipTriggerEvent) {
       this.dispatchEvent(new CustomEvent(CanvasEvent.BEFORE_DESTROY));
     }

diff --git a/packages/g-lite/src/utils/memoize.ts b/packages/g-lite/src/utils/memoize.ts
@@ -21,8 +21,15 @@ export function memoize<F = (...args: unknown[]) => unknown>(
     return result;
   };
   memoized.cache = new (memoize.Cache || Map)();
+  memoize.cacheList.push(memoized.cache);
 
   return memoized as F;
 }
 
 memoize.Cache = Map;
+memoize.cacheList = [];
+memoize.clearCache = () => {
+  memoize.cacheList.forEach((cache) =>
+    (cache as unknown as Map<unknown, unknown>).clear(),
+  );
+};