Add bracketMatching #127
Open
Add bracketMatching #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyfung1031
force-pushed
the
bracket-matching
branch
from
cdb80f9 to
c1bec94
Compare
cyfung1031
force-pushed
the
bracket-matching
branch
from
c1bec94 to
c39d0a9
Compare
|
Very nice! One core feature of codejar - the size. Can we try to implement this as addition to codejar? Maybe in separate file (codejar/matching-brackets.ts). This waty to can add a lot of functionality while still keep the size of the codejat small. We can add some modifications to codejar to keep make adding integrations possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature similar to VSCode that we can see the brackets when cursor moves.
For most highlighters, they will mark the brackets as an independent token so we can easily match them without knowing their exact tokens (i.e. token information before HTML rendering is not required)