Skip to content

Initial GitHub Actions and Infection setting setup #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 1.x.x
Choose a base branch
from

Conversation

peter279k
Copy link
Member

Description

  • Initial GitHub actions, improve PHP_CondSniffer setting and Infection setting setup.

Motivation and context

  • Since Travis CI is not friendly for open source projects, it should transfer to the GitHub Workflow.
  • Adding the specific directory to check coding style on phpcs.xml.dist file.
  • Initialize Infection setup.

How has this been tested?

N/A

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@peter279k peter279k self-assigned this Nov 18, 2021
@peter279k peter279k requested a review from kpicaza November 18, 2021 09:26
Copy link
Member

@kpicaza kpicaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a small request change to run actions both for PHP 7.4 and 8.0, Very nice job, and thank you very much for your excellent work;-D

dependencies:
- "locked"
php-version:
- "7.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "7.4"
- "7.4"
- "8.0"

dependencies:
- "locked"
php-version:
- "7.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "7.4"
- "7.4"
- "8.0"

dependencies:
- "locked"
php-version:
- "7.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "7.4"
- "7.4"
- "8.0"

dependencies:
- "locked"
php-version:
- "7.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "7.4"
- "7.4"
- "8.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants