fix: parse ALL --allowed-tools flags, not just the first one #801
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #800
The
parseAllowedTools()function previously used.match()which only returns the first match. This caused tools specified in subsequent--allowed-toolsflags to be ignored during MCP server initialization.Changes
/gflag to regex patterns for global matchingmatchAll()to find all occurrencesRoot Cause
When users specify multiple
--allowed-toolsflags:Only tools from the first flag were parsed. This broke MCP server initialization when
mcp__github_*tools weren't in the first flag.Test plan
--allowed-toolsflags