Fix CI/CD security to follow zizmor recommendations #767
+244
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmissions - Updated actions/checkout to a specific commit for consistency. - Updated oven-sh/setup-bun to specific commits for version control. - Added permissions to various jobs to enhance security and control. - Introduced a new job 'zizmor' for running the zizmor action. - Ensured all workflows now include 'persist-credentials: false' for better credential management.
- Introduced a new .github/zizmor.yml file. - Configured rules to ignore specific lines in release.yml that require persist-credentials for git push operations.
Contributor
Author
|
@ashwin-ant The previous PR #763 was motivated by a recent CTF I participated in. Since then, I’ve found a convenient tool for vulnerability validation, so in this PR I’ve addressed the vulnerability and introduced CI using that tool. I’d appreciate your review. |
kiwamizamurai
commented
Dec 24, 2025
| persist-credentials: false | ||
|
|
||
| - name: Run zizmor | ||
| uses: zizmorcore/zizmor-action@e639db99335bc9038abc0e066dfcd72e23d26fb4 # v0.3.0 |
Contributor
Author
There was a problem hiding this comment.
kiwamizamurai
commented
Dec 24, 2025
| ignore: | ||
| # These checkouts need persist-credentials for git push to create/update tags | ||
| - release.yml:23 | ||
| - release.yml:99 No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Securing our CI/CD pipeline using Zizmor
Type of change
Changes
uses: [email protected]touses: ...@<commit-sha> # v1.2.3permissions: {}at workflow level, minimal permissions per job)persist-credentials: falseonactions/checkoutwhere credentials are not neededzizmor.ymlconfiguration to document intentional exceptions and the job in ci.ymlResults
other repos using zizmor