Skip to content

fix: use conditional import for NotRequired to match dependency spec #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harupy wants to merge 1 commit into from
Closed

fix: use conditional import for NotRequired to match dependency spec #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/claude_agent_sdk/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@
from pathlib import Path
from typing import TYPE_CHECKING, Any, Literal, TypedDict

from typing_extensions import NotRequired
Copy link
Contributor Author

@harupy harupy Nov 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the mcp package (and many packages also) requries typing_extensions, this import actually doesn't fail even in Python >= 3.11

try:
# Python >= 3.11
from typing import NotRequired
except ImportError:
# Python < 3.11
from typing_extensions import NotRequired

if TYPE_CHECKING:
from mcp.server import Server as McpServer
Expand Down
Loading