Skip to content

fix: defer CLI path lookup to async context to prevent blocking calls #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
torykit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: defer CLI path lookup to async context to prevent blocking calls #325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/claude_agent_sdk/_internal/transport/subprocess_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
"""Subprocess transport implementation using Claude Code CLI."""

import asyncio
import json
import logging
import os
Expand Down Expand Up @@ -48,9 +49,7 @@ def __init__(
self._prompt = prompt
self._is_streaming = not isinstance(prompt, str)
self._options = options
self._cli_path = (
str(options.cli_path) if options.cli_path is not None else self._find_cli()
)
self._cli_path = str(options.cli_path) if options.cli_path is not None else None
self._cwd = str(options.cwd) if options.cwd else None
self._process: Process | None = None
self._stdout_stream: TextReceiveStream | None = None
Expand Down Expand Up @@ -266,6 +265,10 @@ async def connect(self) -> None:
if self._process:
return

# Defer CLI path lookup to async context to avoid blocking calls
if self._cli_path is None:
self._cli_path = await asyncio.to_thread(self._find_cli)

if not os.environ.get("CLAUDE_AGENT_SDK_SKIP_VERSION_CHECK"):
await self._check_claude_version()

Expand Down