Repository navigation
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
An extension of a MessageSet can be numbered above 2^29 - 1, and Extension does not know its extendee's wire format, so the constructors assert only that the number is nonzero and at most i32::MAX. The reserved band 19000 to 19999 is a schema rule that DescriptorPool applies; a number in it encodes and decodes like any other. The changelog entry moves to Changed: the constructors gain a panic.
Field number 0 was documented as accepted and inert, so a hand-written const with 0 compiled; the changelog entry is now a breaking change and says so. The constructors and the check carry track_caller, the check has one assertion per rule, and a compile_fail doctest shows the const case. The MessageSet type-ID ceiling gets one name that the item decoder and the constructors share. The module Panics section is the one list of accessors that check the extendee; the other docs and the guide refer to it.
The bound applies to every call; MessageSet extensions are the reason for it, not its scope.
Collaborator
|
[claude code] Thanks for adding the check. Maintainer commits on top, after a merge of main:
|
iainmcgin
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Implementation