Repository navigation
json: reject null elements in closed enum containers - #594
Merged
iainmcgin merged 6 commits intoOct 12, 2026
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
# Conflicts: # buffa/src/json_helpers.rs
# Conflicts: # buffa/src/json_helpers.rs
Collaborator
|
[claude code] Thanks for the fix and for testing it through proto2, editions and the no_std path. #691 edited the next line of the same function and has merged, so this branch needed a merge. Maintainer commits on top of yours: merges of main, with the one conflict resolved by keeping your |
iainmcgin
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
nullentries in closed enum lists and maps.Why
{"tiers":[null]}was accepted as the default enum value.Implementation
nullhandling.