Repository navigation
table: keep dense lookup for wide messages - #517
Open
fallintoplace wants to merge 1 commit into
Open
fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Collaborator
|
[claude code] Thanks for this. The change is correct: the dense array is filled only for field numbers below 64, entries are sorted by field number, so such a field is at index 62 or lower and its index-plus-one always fits a It is on hold for ordering, not for content. It conflicts with the open table codec stack (#475 to #478) in
There is no action for you in the meantime. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Keep dense lookup for low field numbers in messages with 255 or more fields.
Why
Wide messages currently fall back to binary search for every field.
Implementation
Keep indices for fields below 64 in the dense lookup table.
Benchmark
Not applicable.