Fix README example: move reset() inside exit callback #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous example called reset() immediately after spawning the child process, which would shut down proxy servers before the child process completes. This caused the sandboxed command to fail. Move reset() inside the 'exit' event callback to ensure cleanup happens after the child process terminates.
ryoppippi
force-pushed
the
ryoppippi/fix-readme-example
branch
from
e055c8a to
0bce87c
Compare
ryoppippi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous example called
reset()immediately after spawning the child process, causing the sandboxed command to fail.This bug cost me about 3 hours to track down.