Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(polar): Use new slug filter vs. deprecated name #83

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

birkjernstrom
Copy link
Contributor

Description

Well this is embarrassing and I apologies for the extra work @antfu 😔 We've done a big refactor of organizations (no longer coupled 1:1 with GitHub) within Polar. Along with it, we've made a subtle change to the API and filtering them by slug vs. name. This PR updates the integration accordingly.

Sorry, I hope and expect we won't make any more changes here at least within 2024 :)

Linked Issues

Additional context

@antfu
Copy link
Member

antfu commented Aug 9, 2024

I am fine taking that. But would you consider version control your APIs in the future?

@birkjernstrom
Copy link
Contributor Author

Thank you @antfu

Yes, our goal is absolutely to version it. Just that we're currently finalizing v1 ☺️ So prior endpoints have been alpha/beta.

Now once we reach v1, we'll prioritize keeping things stable and introducing true versioning once we have to introduce any breaking changes.

@antfu antfu merged commit 37be228 into antfu-collective:main Aug 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants