This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Automatic download manager for binaries#2
Open
DiMartinoXBMC wants to merge 54 commits intoanteo:masterfrom
Open
Automatic download manager for binaries#2DiMartinoXBMC wants to merge 54 commits intoanteo:masterfrom
DiMartinoXBMC wants to merge 54 commits intoanteo:masterfrom
Conversation
You are killing a subprocess without check never the result status, so you are leaking zombie processes: ``` osmc@osmc:~$ ps aux | grep http osmc 19187 0.0 0.0 0 0 ? ZN 22:35 0:00 [torrent2http] <defunct> osmc 19205 0.0 0.0 0 0 ? ZN 22:35 0:01 [torrent2http] <defunct> osmc 19258 0.0 0.0 0 0 ? ZN 22:37 0:00 [torrent2http] <defunct> osmc 19274 1.1 0.0 0 0 ? ZN 22:37 0:19 [torrent2http] <defunct> osmc 19347 0.1 0.0 0 0 ? ZN 22:39 0:01 [torrent2http] <defunct> osmc 19363 0.0 0.0 0 0 ? ZN 22:40 0:00 [torrent2http] <defunct> osmc 19463 0.0 0.0 0 0 ? ZN 22:43 0:00 [torrent2http] <defunct> osmc 19482 0.0 0.0 0 0 ? ZN 22:44 0:00 [torrent2http] <defunct> osmc 19498 2.1 0.0 0 0 ? ZN 22:44 0:26 [torrent2http] <defunct> osmc 19543 0.0 0.0 0 0 ? ZN 22:45 0:00 [torrent2http] <defunct> osmc 19559 0.0 0.0 0 0 ? ZN 22:45 0:00 [torrent2http] <defunct> osmc 19576 0.0 0.0 0 0 ? ZN 22:45 0:00 [torrent2http] <defunct> osmc 19591 2.3 0.0 0 0 ? ZN 22:45 0:28 [torrent2http] <defunct> osmc 19642 0.0 0.0 0 0 ? ZN 22:47 0:00 [torrent2http] <defunct> osmc 19658 2.1 0.0 0 0 ? ZN 22:47 0:22 [torrent2http] <defunct> osmc 19705 2.1 0.0 0 0 ? ZN 22:49 0:19 [torrent2http] <defunct> ``` With wait() Python reads the termination status and the SO removes the zombie process.
Fix process leak
# Conflicts: # addon.xml
Client/Server, Standalone
Web UI for server
# Conflicts: # addon.xml
Новая порция
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after merge you should change libbaseurl in download.py