Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 23, 2025

The cpal upgrade from 0.16.0 to 0.17.0 introduced a breaking change where SampleRate changed from a struct to a u32 type alias.

Changes

  • cli/src/main.rs: Removed .0 field access from sample_rate() call since it now returns u32 directly
// Before (cpal 0.16.0)
let engine = Engine::new(rx, config.sample_rate().0 as f32);

// After (cpal 0.17.0)
let engine = Engine::new(rx, config.sample_rate() as f32);

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copy link
Contributor Author

Copilot AI commented Dec 23, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libobject-2dc10b344e05b569.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libmemchr-09f2ab7e0d97e07a.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libaddr2line-11d54e777384a9e5.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libgimli-35018e994bad7042.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libcfg_if-6a40188dd7d989d2.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/librustc_demangle-43b2ff22c18e1125.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libstd_detect-5978f0713dd5442d.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libhashbrown-2ed6a8f06fc51a9d.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-u�� /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libminiz_oxide-5312b588e5cfab93.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libadler2-1e0b0d62df36c85c.rlib 64-u�� 64-REDACTED-linux-gnu/lib/libstd_detect-5978f0713dd5442d.rlib 64-REDACTED-linux-gnu/lib/libhashbrown-2ed6a8f06fc51a9d.rlib (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Bump cpal from 0.16.0 to 0.17.0 in /cli Fix cpal 0.17.0 API compatibility in sample rate usage Dec 23, 2025
Copilot AI requested a review from antbern December 23, 2025 09:29
@antbern antbern marked this pull request as ready for review December 23, 2025 09:57
@antbern antbern merged commit 356d44d into dependabot/cargo/cli/cpal-0.17.0 Dec 23, 2025
@antbern antbern deleted the copilot/sub-pr-50 branch December 23, 2025 09:59
antbern added a commit that referenced this pull request Dec 23, 2025
* Bump cpal from 0.16.0 to 0.17.0 in /cli

Bumps [cpal](https://github.com/RustAudio/cpal) from 0.16.0 to 0.17.0.
- [Release notes](https://github.com/RustAudio/cpal/releases)
- [Changelog](https://github.com/RustAudio/cpal/blob/master/CHANGELOG.md)
- [Commits](RustAudio/cpal@v0.16.0...v0.17.0)

---
updated-dependencies:
- dependency-name: cpal
  dependency-version: 0.17.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix cpal 0.17.0 API compatibility in sample rate usage (#51)

* Initial plan

* Fix compiler error: remove .0 from sample_rate() call for cpal 0.17.0

Co-authored-by: antbern <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: antbern <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: antbern <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants