fix(android): Prevent ArrayIndexOutOfBoundsException in permission check #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses a potential ArrayIndexOutOfBoundsException in the Android module's permission checking logic. ```diff - results.length > 0 && results[j] == PackageManager.PERMISSION_GRANTED + results.length > j && results[j] == PackageManager.PERMISSION_GRANTED ``` This change ensures that we only access the results array when the index j is within bounds, preventing crashes due to invalid array access that have been occurring in the production environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses a potential
ArrayIndexOutOfBoundsExceptionin the Android module's permission checking logic.It ensures that we only access the results array when the index
jis within bounds, preventing crashes due to invalid array access that have been occurring in the production environment.Here is the Crashlytics dashboard concerning this type of crash on my app last week (react-native 0.75.4 - old arch):
Changelog:
[ANDROID] [FIXED] - Prevent ArrayIndexOutOfBoundsException in permission check