generated from ansys/template
-
Notifications
You must be signed in to change notification settings - Fork 7
feat: refactor source class #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pluAtAnsys
wants to merge
64
commits into
main
Choose a base branch
from
refactor/source
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 51 commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
5b5d11e
refactor BaseSensorClass
StefanThoene 0990b59
refactor SourceLuminaire
e151c5d
refactor the spectrum.py
2112d08
refactor the luminaire source class
1b62c6d
luminaire and spectrum constant values in constants.py
e8d2d27
update the test related to luminaire source class
c11dc96
update the source example related to luminaire source
359eeb6
refactor the Luminous and Radiant to BaseSource class
85ae2f1
refactor rayfile source
30744e7
refactor the test and example using new rayfile source methods
75cbaea
refactor the surface source class
a644db0
update the source test and example
b0ef0db
Merge branch 'main' into refactor/source
pluAtAnsys 0fab2d4
chore: adding changelog file 690.added.md [dependabot-skip]
pyansys-ci-bot f636777
fix issue and change default mono spectrum value
da67f35
update other tests based on the new refactor methods from source.py
fef8ac7
fix visual data issue
2a5bf45
update other examples related to source refactor methods
e51350b
fix issue in sensor test and sensor class
1f7a9f4
fix sensor refactor methods related in prism-example.py
8f42a9c
fix issue in project.py
1719bf5
fix example issue
c7fc8af
fix issue in document example
4ebbc84
improve code coverage
94b53f3
issue fix in test
56dd33d
improve code coverage
749ea89
improve code coverage
aaa84d0
Update src/ansys/speos/core/source.py
pluAtAnsys 5426819
Update src/ansys/speos/core/source.py
pluAtAnsys 28ca1dc
Update src/ansys/speos/core/source.py
pluAtAnsys 5767315
Update src/ansys/speos/core/generic/constants.py
pluAtAnsys 06c33ed
Update src/ansys/speos/core/source.py
pluAtAnsys 4e520bc
ci: auto fixes from pre-commit.com hooks.
pre-commit-ci[bot] 10c6a2d
Update src/ansys/speos/core/source.py
pluAtAnsys 3d20f79
fix issue and add exitgeometry sub-class
13130d0
improve code coverage
df97791
Merge branch 'main' into refactor/source
pluAtAnsys c14208f
refactor cheat_sheet_script.qmd content accordingly
7259117
refactor the intensity type of flux into BaseSource class
b86d00f
add test reference result from constants
da7e5f0
refactor the flux type class
4786dba
refactor the flux class and corresponding unittests
8512e07
chore: adding changelog file 690.added.md [dependabot-skip]
pyansys-ci-bot 58e6075
clean the comments
033a969
Merge remote-tracking branch 'origin/refactor/source' into refactor/s…
985ab5c
Merge branch 'main' into refactor/source
pluAtAnsys b7c4ad4
correct example document
e281307
refactor the flux properties
49979bc
refactor the example
339887d
Merge branch 'main' into refactor/source
pluAtAnsys 8903fa0
constants.py default values
ae3f817
Merge branch 'main' into refactor/source
pluAtAnsys e522762
refactor the constant class
c1b392a
Merge branch 'main' into refactor/source
pluAtAnsys c29c6f1
fix mutable variable
bed1f71
Merge remote-tracking branch 'origin/refactor/source' into refactor/s…
06294a6
refactor the constants.py to address default parameters
fec559e
Merge branch 'main' into refactor/source
pluAtAnsys 0b3bf19
apply the constants.py discussion
8caa372
Merge branch 'main' into refactor/source
pluAtAnsys 11a453e
Merge branch 'main' into refactor/source
pluAtAnsys d99d8b1
change to constants.py ORIGIN
fee28f8
Merge remote-tracking branch 'origin/refactor/source' into refactor/s…
823781c
add comparison with value from default parameter instance
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Refactor source class |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.