React to 401 http errors, execute a callback and retry the request #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimanikant
requested review from
FedericoNegri,
nezgrath and
ojkoenig
as code owners
…nto maint/401_http
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
- Coverage 84.22% 84.10% -0.13%
==========================================
Files 17 17
Lines 1509 1560 +51
==========================================
+ Hits 1271 1312 +41
- Misses 238 248 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
maintenance
github-actions
bot
added
maintenance
github-actions
bot
added
maintenance
github-actions
bot
added
maintenance
github-actions
bot
added
maintenance
github-actions
bot
added
maintenance
github-actions
bot
added
maintenance
| >>> from ansys.hps.data_transfer.client import Client | ||
| >>> token = authenticate(username=username, password=password, verify=False, url=auth_url) | ||
| >>> token = token.get("access_token", None) | ||
| >>> def refresh_token(): |
Collaborator
There was a problem hiding this comment.
maybe call it refresh_token_cb or similar to disambiguate from the refresh_token itself
| >>> token = token.get("access_token", None) | ||
| >>> def refresh_token(): | ||
| # Function to refresh the token | ||
| token = authenticate(username=username, self.password, verify=False, url=auth_url) |
Collaborator
There was a problem hiding this comment.
self.password --> just password?
| def __init__(self, *args, refresh_token_callback: Callable[[], Awaitable[str]] = None, **kwargs): | ||
| """Initializes the AsyncClient class object.""" | ||
| super().__init__(*args, **kwargs) | ||
| self.refresh_token_callback = refresh_token_callback # Override the callback |
Collaborator
There was a problem hiding this comment.
why do you need to override it?
Collaborator
Author
There was a problem hiding this comment.
overriding refresh_token_callback in the AsyncClient class for it to be asynchronous (Callable[[], Awaitable[str]]) because the parent class defines it (Callable[[], str])
Collaborator
There was a problem hiding this comment.
The changes here as well as the content of the async version (with the loop on get storage) seem to me more of a script to test tokens than an examples. It's fine to keep this code around as a script, but I think it should not a user-facing example.
github-actions
bot
added
maintenance
github-actions
bot
added
maintenance
github-actions
bot
added
maintenance
github-actions
bot
added
maintenance
github-actions
bot
added
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing: #106
How to test:
In data-transfer config add:
"auth": {
"auto_config_worker": true
}
Restart docker service, set Access Token Lifespan to something like 30 second.
Can we do more with testing?
Do we want a callback for AsyncClient as well?
Checklist