Skip to content

REFACTOR: Grpc cfg setup clean #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Apr 25, 2025
Merged

REFACTOR: Grpc cfg setup clean #1148

merged 29 commits into from
Apr 25, 2025

Conversation

svandenb-dev
Copy link
Collaborator

Cleaning duplicated code between grpc and dotnet.

# Conflicts:
#	src/pyedb/grpc/database/layout/layout.py
# Conflicts:
#	src/pyedb/configuration/cfg_setup.py
@svandenb-dev svandenb-dev requested a review from hui-zhou-a April 22, 2025 13:51
@svandenb-dev svandenb-dev changed the title REFACT: Grpc cfg setup clean REFACTOR: Grpc cfg setup clean Apr 22, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.02%. Comparing base (7b3f250) to head (cadfab5).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
+ Coverage   82.00%   82.02%   +0.02%     
==========================================
  Files         161      161              
  Lines       22714    22706       -8     
==========================================
- Hits        18626    18625       -1     
+ Misses       4088     4081       -7     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svandenb-dev svandenb-dev merged commit 62801a5 into main Apr 25, 2025
26 checks passed
@svandenb-dev svandenb-dev deleted the grpc-cfg-setup-clean branch April 25, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants