Skip to content

feat: update with delta #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 78 commits into
base: main
Choose a base branch
from
Open

feat: update with delta #1922

wants to merge 78 commits into from

Conversation

umutsoysalansys
Copy link
Contributor

@umutsoysalansys umutsoysalansys commented Apr 18, 2025

Description

** This Pr introduces a new method to update design object using new trackers coming from API Server. Currently we are trying to keep the synchronization between client and server by updating whole design document after each operation that can possibly cause a change on the backend which is an expensive effort. Recently developed trackers are allowing us to get the only delta from each geometry manipulation operation and the method in this PR updates the design recursively using the information coming from tracker.

It is currently hidden behind a feature flag, for extensive testing and further improvements. **

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@umutsoysalansys umutsoysalansys changed the title Feat/update with delta feat: update with delta Apr 18, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Apr 18, 2025
@umutsoysalansys
Copy link
Contributor Author

Looks like all the tests have gone through in the end @umutsoysalansys! Are you still experiencing issues locally? I left a first review with some comments. Let me know once I can do a final review. Thanks for all the work here, this looks promising!

Yes because it is also behind the feature flag which is set to False as default ( so update design inplace is activated) The full test suit with the tracker is still failing in 2 tests because of some potential leak on Geometry Service side but all tests are passing individually and still following up on that issue with @david-gorman @b-matteo. Once it is resumed we can working on changing the flag with extensive testing.

@RobPasMue
Copy link
Member

Yes because it is also behind the feature flag which is set to False as default ( so update design inplace is activated)

Oh you are completely right! I missed that part.. I need to get back on the debugging as well, thanks for clarifying it @umutsoysalansys! I did some early debugging on Friday and Monday but nothing clear popped up yet... let's see if I can continue to investigate as well on my side.

Thanks a lot for all the refactoring and answering all comments!

@umutsoysalansys umutsoysalansys requested a review from smereu June 10, 2025 17:55
@RobPasMue
Copy link
Member

Bug was reproduced locally -- seems like the server response sometimes doesn't work well. We would need to debug on the server a bit more to understand what happened. We will set up a debug session with @umutsoysalansys and whoever is interested (@david-gorman @b-matteo) once @umutsoysalansys is back from vacations

@smereu
Copy link
Contributor

smereu commented Jun 16, 2025

@RobPasMue Thanks for the comment! If the issue is easily reproduced, we can try to look at it this week as it appears to be entirely on the server side. @david-gorman please correct if me I am wrong but you were not able to reproduce it your machine. My guess is that there is some memory leak that grows the memory and David's machine being a powerful one with a lot of memory may be able to survive....

@RobPasMue
Copy link
Member

RobPasMue commented Jun 16, 2025

@RobPasMue Thanks for the comment! If the issue is easily reproduced, we can try to look at it this week as it appears to be entirely on the server side. ... My guess is that there is some memory leak that grows the memory and David's machine being a powerful one with a lot of memory may be able to survive....

That could be it, most definitely! let's bring it offline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants