Skip to content

Conversation

@Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Nov 17, 2025

Description

PyAEDT needs to define LD_LIBRARY_PATH to work in Linux, but this can ba avoided if PyAEDT loads the needed DLLs. This is needed because this variable is used by other libraries like vtk, and it is starting to have too many conflicts.

Issue linked

Close #6878

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.50%. Comparing base (ad751d8) to head (ee650f1).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6883       +/-   ##
===========================================
- Coverage   83.51%   28.50%   -55.01%     
===========================================
  Files         246      246               
  Lines       77863    77875       +12     
===========================================
- Hits        65025    22201    -42824     
- Misses      12838    55674    +42836     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys Samuelopez-ansys marked this pull request as ready for review November 17, 2025 09:25
@Samuelopez-ansys Samuelopez-ansys requested a review from a team as a code owner November 17, 2025 09:25
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great changes @Samuelopez-ansys I left minor comments.
@svandenb-dev I think this might also be something of interest for pyedb's repo :)

@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft November 17, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove LD_LIBRARY_PATH definition in PyAEDT

4 participants