Skip to content

Conversation

@tizianrot
Copy link
Contributor

Description

Method for inception voltage evaluation added to post_maxwell.py.

Issue linked

#5310

Checklist

  • [ x] I have tested my changes locally.
  • [x ] I have added necessary documentation or updated existing documentation.
  • [ x] I have followed the coding style guidelines of this project.
  • [ x] I have added appropriate tests (unit, integration, system).
  • [ x] I have reviewed my changes before submitting this pull request.
  • [ x] I have linked the issue or issues that are solved by the PR if any.
  • [x ] I have agreed with the Contributor License Agreement (CLA).

@tizianrot tizianrot requested a review from a team as a code owner November 11, 2025 10:54
@github-actions github-actions bot added the enhancement New features or code improvements label Nov 11, 2025
@gmalinve
Copy link
Contributor

@tizianrot , great job! could you please link to the corresponding existing issue? thanks :)

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor typo in the docstrings

@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft November 19, 2025 11:38
@tizianrot tizianrot marked this pull request as ready for review November 19, 2025 13:42
@gmalinve gmalinve changed the title Added method for Inception Voltage Evaluation for electrostatic Maxwell analyses. Issue #5310 FEAT: Added method for Inception Voltage Evaluation for electrostatic Maxwell analyses. Issue #5310 Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.11%. Comparing base (7241568) to head (86b05e3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6869      +/-   ##
==========================================
- Coverage   82.18%   81.11%   -1.08%     
==========================================
  Files         247      247              
  Lines       78177    78163      -14     
==========================================
- Hits        64248    63400     -848     
- Misses      13929    14763     +834     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gmalinve
gmalinve previously approved these changes Nov 25, 2025
Copy link
Contributor

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmalinve gmalinve merged commit c6f9a48 into main Nov 25, 2025
40 checks passed
@gmalinve gmalinve deleted the feat_inception_voltage branch November 25, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in Maxwellxd.post.create_fieldplot_line_traces: does not pass object names correctly Add Inception Voltage Evaluation Capability

5 participants