Automatically set lightspeed and inline suggestion checkboxes to enabled when user clicks Connect #1789
+87
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabashian
force-pushed
the
mabashian/AAP-31064
branch
from
6ae3566 to
5eba635
Compare
mabashian
force-pushed
the
mabashian/AAP-31064
branch
from
9f321c7 to
078808e
Compare
mabashian
force-pushed
the
mabashian/AAP-31064
branch
from
078808e to
ca38c75
Compare
…led when user clicks Connect
mabashian
force-pushed
the
mabashian/AAP-31064
branch
from
ca38c75 to
4b6ac11
Compare
goneri
requested changes
Jan 29, 2025
| ); | ||
| } | ||
|
|
||
| if (!lightSpeedSuggestionsEnabled) { |
There was a problem hiding this comment.
IMO, if the value is already set to true, nothing bad will happen.
I don't think we need to read lightSpeedSuggestionsEnabled first. This increases the complexity of the code, and reduce the test coverage, without bringing any tangible value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/AAP-31064
The basic gist of this change is that when we catch the "connect" message and before we initiate the login flow, we update ansible.lightspeed.enabled and ansible.lightspeed.suggestions.enabled to be true (if they're not already true).
I found that I needed to update the status bar logic since that gets triggered by the programatic settings update and the scenario where a user is not yet logged in wasn't explicitly handled. Without this change, the modal never appears after clicking
ConnectAs far as the tests go, I extended what was already there in the ui tests to include two scenarios:
In both cases the tests confirm that the checkboxes are checked after login