Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type to smartFilter #1262

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add type to smartFilter #1262

merged 1 commit into from
Apr 22, 2024

Conversation

ssbarnea
Copy link
Member

Related: #1225

@ssbarnea ssbarnea requested a review from priyamsahoo April 22, 2024 11:44
@ssbarnea ssbarnea marked this pull request as ready for review April 22, 2024 11:44
@ssbarnea ssbarnea requested review from a team as code owners April 22, 2024 11:44
@ssbarnea ssbarnea requested a review from shatakshiiii April 22, 2024 11:44
@ssbarnea ssbarnea merged commit 890ecb5 into main Apr 22, 2024
13 checks passed
@ssbarnea ssbarnea deleted the chore/type-fuse branch April 22, 2024 11:57
audgirka
audgirka reviewed Apr 22, 2024
View reviewed changes
packages/ansible-language-server/test/helper.ts
.search(triggerCharacter)
.slice(0, 5)
.map((completion) => {
return completion.item;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssbarnea if it's a single item, we can just return it like

.map(completion => completion.item);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audgirka audgirka audgirka left review comments

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
skip-changelog
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssbarnea @audgirka