Open
Conversation
shanemcd
reviewed
Aug 23, 2023
execution-environment.yml
Outdated
| python-daemon | ||
| pyyaml | ||
| six | ||
| google-cloud-storage |
Member
There was a problem hiding this comment.
Which collection depends on this? We should avoid adding deps directly to awx-ee whenever possible.
Author
There was a problem hiding this comment.
The google-cloud-storage is required for many of the GCP collections. I really only included it per the previous comments. I could see the argument that it is more of a 3rd party dependency and should not be included. The overall PR is more focused on ansible.utils due to calls to netaddr.
Shall I remove the google-cloud-storage addition?
Author
There was a problem hiding this comment.
Removed the google-cloud-storage python module to keep things light. This is now just adding ansible.utils.
AdamEldred
changed the title
|
Any updates on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding just the requirements for ansible.utils (Galaxy) and google-cloud-storage (PIP) per the comments here: #92 (review)
Validated this resolves issues with netaddr requirements in AWX, namely:
Failed to import the required Python library (netaddr) on automation-job's Python /usr/bin/python3.