Skip to content

Install unzip into the image#178

Merged
shanemcd merged 1 commit intoansible:develfrom
Himura2la:patch-1
Jun 16, 2023
Merged

Install unzip into the image#178
shanemcd merged 1 commit intoansible:develfrom
Himura2la:patch-1

Conversation

@Himura2la
Copy link
Contributor

Fix #120

@austlane
Copy link
Contributor

Since this is necessary for a builtin to function. AWX-EE should probably have it included. 👍

@Himura2la Himura2la mentioned this pull request Feb 22, 2023
@Himura2la
Copy link
Contributor Author

Himura2la commented Feb 22, 2023

I was not sure, so I made it bulletproof. If debian-based systems are not required to support, I also propose #180, so that it does not confuse others (like it confused me).

@Himura2la Himura2la requested a review from austlane February 22, 2023 04:51
@rebeccahhh rebeccahhh requested review from relrod and removed request for austlane February 23, 2023 11:14
@relrod
Copy link
Contributor

relrod commented Jun 8, 2023

@Himura2la Sorry for the delay here. I agree this probably should be included since an ansible-core module depends on it.

We've redone how the EE gets built now, could rebase your PR and instead add the line to the system requirements in execution_environment.yml?

Thanks much!

Copy link
Contributor

@austlane austlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@shanemcd shanemcd enabled auto-merge (rebase) June 16, 2023 14:31
@shanemcd shanemcd merged commit b675d0c into ansible:devel Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unarchive missing from runners

4 participants