fix: handle missing directories in docs-build test #3297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs-build.py checker was failing with FileNotFoundError when trying to copy directories and files that don't exist in the repository (such as 'bin', 'lib', etc.). These directories are only present after cloning ansible-core using 'nox -s clone-core'. This fix adds existence checks before attempting to copy directories and files, making the test more robust and preventing errors when running in environments where ansible-core hasn't been cloned yet.
ZerocouldBR
temporarily deployed
to
github-bot
GitHub Actions
Inactive
Contributor
|
@ZerocouldBR Thanks for the pull request. It looks like your branch needs to be rebased against devel. In the While on devel it should be 3.12: ansible-documentation/.readthedocs.yaml Line 11 in f67c54c |
Collaborator
|
I think the tests should fail if the files it needs aren't there. I guess the error message could be improved on, but the check shouldn't run (and potentially pass) when things it needs aren't there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs-build.py checker was failing with FileNotFoundError when trying to copy directories and files that don't exist in the repository (such as 'bin', 'lib', etc.). These directories are only present after cloning ansible-core using 'nox -s clone-core'.
This fix adds existence checks before attempting to copy directories and files, making the test more robust and preventing errors when running in environments where ansible-core hasn't been cloned yet.