Skip to content

Collection requirements: declare that Galaxy artifacts must not be deleted once they appear in Ansible releases #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

felixfontein
Copy link
Collaborator

This updates the Ansible community package collections requirements. This change was prompted by the deletion of a collection release already contained in Ansible 12.0.0b4, which broke the build of that release, and also of all newer and upcoming Ansible 12 releases (as the changelog can no longer be built).

@ansible-documentation-bot ansible-documentation-bot bot added the sc_approval This PR requires approval from the Ansible Community Steering Committee label Jun 3, 2025
@bcoca
Copy link
Member

bcoca commented Jun 3, 2025

I would go a step further and mention you cannot delete versions of a collection that would break the build:

for example, you require my.coll >= 2.0, deleting everything except 1.9 version would still break the build.

@felixfontein
Copy link
Collaborator Author

@bcoca this is implicitly handled for collections included in Ansible, since all dependencies also have to be part of it, hence these might also not be deleted.

For general collections the situation is different, but these aren't covered by these requirements anyway.

@felixfontein felixfontein changed the title [WIP] Collection requirements: declare that Galaxy artifacts must not be deleted once they appear in Ansible releases Collection requirements: declare that Galaxy artifacts must not be deleted once they appear in Ansible releases Jun 13, 2025
@felixfontein felixfontein marked this pull request as ready for review June 13, 2025 11:02
@felixfontein felixfontein requested a review from a team as a code owner June 13, 2025 11:02
@felixfontein felixfontein added backport-2.18 Automatically create a backport for the stable-2.18 branch backport-2.19 Automatically create a backport for the stable-2.19 branch labels Jun 13, 2025
@felixfontein
Copy link
Collaborator Author

Approved according to https://forum.ansible.com/t/43132/13.

@felixfontein felixfontein merged commit a514f0c into ansible:devel Jun 13, 2025
12 checks passed
Copy link

patchback bot commented Jun 13, 2025

Backport to stable-2.18: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.18/a514f0c6073e7784e2b4953a61b447c1eaec22e6/pr-2678

Backported as #2722

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator Author

@bcoca @gotmax23 @mariolenz thanks!

@felixfontein felixfontein deleted the delete branch June 13, 2025 11:03
patchback bot pushed a commit that referenced this pull request Jun 13, 2025
Copy link

patchback bot commented Jun 13, 2025

Backport to stable-2.19: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.19/a514f0c6073e7784e2b4953a61b447c1eaec22e6/pr-2678

Backported as #2723

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.18 Automatically create a backport for the stable-2.18 branch backport-2.19 Automatically create a backport for the stable-2.19 branch sc_approval This PR requires approval from the Ansible Community Steering Committee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants