-
Notifications
You must be signed in to change notification settings - Fork 615
Build and deploy to latest once a week, running at the start of the week #2487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Here's some feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, this could be combined into one weekly-build workflow with a Matrix for the latest build and the devel build.
@gotmax23 Thanks for providing the feedback to @x1101 - We discussed this at the DaWGs meeting today. @samccann advised that we increase the schedule frequency for Initially I also said to @x1101 that we might just merge his two workflows as separate and then combine them as a follow up. I thought that might make his life a bit easier because he mentioned he is short on time but would like to make this contribution to the docs. It then occurred to me that it might be a lot cleaner for the repo itself if we combine the two workflows and use a matrix as you say. That would avoid old, unused jobs in the actions section. I could push to this branch but I'd rather not stomp on anyone's work. So here comes some stuff for discussion (crontab for devel needs updating):
This was the road I started going down at first but hit a wall because I can't add a conditional like this:
Apparently you can't use the matix context in jobs.job.if, which appears to be a known thing. Is the alternative here to take the schedule out of the matrix and do something like this instead?
If that's the case, I'm not sure I'd be in favour of combining the two workflows. What do folks think? |
Thanks for keeping up the work on this @x1101 |
Yeah, if we want the latest and devel builds to be on different schedules, then keeping them in separate workflows make sense. @x1101, it looks like this PR and #2486 now contain the same files. Would you like to close one of them and implement both #2050 and #2049 in a single PR? Currently, I'm not sure which one I should review. Thanks everyone! |
@gotmax23 yea, I see that now. I'll close this PR for now, and then open one that has both individual fixes in it. Once that's in and working as we'd like, we can revisit the single file matrix of builds option. |
Fixes #2050