Skip to content

Update interpreter_discovery for changes made in ansible-core 2.17 #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 6, 2025

Conversation

HarmtH
Copy link
Contributor

@HarmtH HarmtH commented Mar 6, 2025

I've updated ansible-core to 2.18, and suddenly got a warning regarding interpreter discovery, which pointed me to this page.

I've read the page and stayed confused why it suddenly happened.

Then I've read the source, and mainly this PR merged in 2.17 changed a lot regarding interpreter discovery.

  • There is no "target OS platform, distribution, and version" list anymore (well, it's empty), so you're always using the fallback list if you don't manually specify an interpreter, and so you'll always get a warning.
  • Therefore this exception is always raised, and the check for legacy never happens, making auto_legacy effectively an alias for auto.
  • Not really important anymore, since the code is never reached, but auto_legacy now uses python3, so seems the legacy option isn't really legacy anymore.

So I've updated the documentation page to reflect these changes.

@ansible-documentation-bot ansible-documentation-bot bot added the new_contributor This PR is the first contribution by a new community member. label Mar 6, 2025
@ansible-documentation-bot
Copy link
Contributor

Thanks for your Ansible docs contribution! We talk about Ansible documentation on Matrix at #docs:ansible.im if you ever want to join us and chat about the docs! We meet on Matrix every Tuesday. See the Ansible calendar for meeting details. We welcome additions to our weekly agenda items too. You can add the dawgs-meeting tag to a forum topic to bring it up at the next meeting.

@oraNod oraNod requested a review from sivel March 11, 2025 16:25
@oraNod oraNod added the techreview needs technical review label Mar 11, 2025
@oraNod oraNod added backport-2.17 Automatically create a backport for the stable-2.17 branch backport-2.18 Automatically create a backport for the stable-2.18 branch labels Mar 11, 2025
@samccann samccann merged commit 02282b8 into ansible:devel May 6, 2025
12 checks passed
Copy link

patchback bot commented May 6, 2025

Backport to stable-2.17: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.17/02282b8d6d26ce584a85472526586ca8b65a81c4/pr-2438

Backported as #2608

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@samccann
Copy link
Contributor

samccann commented May 6, 2025

Thanks @HarmtH for the Ansible docs fix!

patchback bot pushed a commit that referenced this pull request May 6, 2025
…2438)

* Update interpreter_discovery for changes made in ansible-core 2.17

* Mention the list searched

* Minor wording improvement

* Remove unnecessary note

* Revert realignment

* Remove trailing space

* Apply suggestions from code review

Co-authored-by: Sloane Hertel <[email protected]>

---------

Co-authored-by: Sloane Hertel <[email protected]>
(cherry picked from commit 02282b8)
Copy link

patchback bot commented May 6, 2025

Backport to stable-2.18: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.18/02282b8d6d26ce584a85472526586ca8b65a81c4/pr-2438

Backported as #2609

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 6, 2025
…2438)

* Update interpreter_discovery for changes made in ansible-core 2.17

* Mention the list searched

* Minor wording improvement

* Remove unnecessary note

* Revert realignment

* Remove trailing space

* Apply suggestions from code review

Co-authored-by: Sloane Hertel <[email protected]>

---------

Co-authored-by: Sloane Hertel <[email protected]>
(cherry picked from commit 02282b8)
samccann pushed a commit that referenced this pull request May 14, 2025
…2438) (#2609)

* Update interpreter_discovery for changes made in ansible-core 2.17

* Mention the list searched

* Minor wording improvement

* Remove unnecessary note

* Revert realignment

* Remove trailing space

* Apply suggestions from code review



---------


(cherry picked from commit 02282b8)

Co-authored-by: Harm te Hennepe <[email protected]>
Co-authored-by: Sloane Hertel <[email protected]>
samccann pushed a commit that referenced this pull request May 14, 2025
…2438) (#2608)

* Update interpreter_discovery for changes made in ansible-core 2.17

* Mention the list searched

* Minor wording improvement

* Remove unnecessary note

* Revert realignment

* Remove trailing space

* Apply suggestions from code review



---------


(cherry picked from commit 02282b8)

Co-authored-by: Harm te Hennepe <[email protected]>
Co-authored-by: Sloane Hertel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.17 Automatically create a backport for the stable-2.17 branch backport-2.18 Automatically create a backport for the stable-2.18 branch new_contributor This PR is the first contribution by a new community member. techreview needs technical review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants